Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Meson] Add an option to compile or not the binaries #360

Merged
merged 3 commits into from
Jan 3, 2025
Merged

Conversation

amontoison
Copy link
Member

@amontoison amontoison commented Jan 2, 2025

@jfowkes @nimgould
I added an option to the Meson build so that the binaries are no longer compiled by default.
I believe the majority of users are not interested in these files, and making their compilation optional seems appropriate from my point of view.

I will wait a green light of you to merge the PR.
Capture d’écran du 2025-01-03 00-02-50

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.40%. Comparing base (e2f6b7b) to head (9208f10).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #360      +/-   ##
==========================================
+ Coverage   41.84%   43.40%   +1.55%     
==========================================
  Files         325      309      -16     
  Lines      167628   161612    -6016     
  Branches    58076    55897    -2179     
==========================================
  Hits        70143    70143              
+ Misses      79992    73976    -6016     
  Partials    17493    17493              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nimgould
Copy link
Contributor

nimgould commented Jan 3, 2025

I don't know what you mean here, does Julia not need binaries? Sorry for my ignorance

@amontoison
Copy link
Member Author

Julia only need the shared libraries, just like Python.
They don't need any executable.

@nimgould
Copy link
Contributor

nimgould commented Jan 3, 2025

OK, I guess it is just a matter of terminology, but here in fortan-land executables are components of libraries. Again, not needed here except for the main programs

@nimgould nimgould merged commit d285318 into master Jan 3, 2025
13 checks passed
@amontoison amontoison deleted the binaries branch January 3, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants