Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update continuous integration #224

Merged
merged 7 commits into from
Jan 13, 2024
Merged

Conversation

amontoison
Copy link
Member

@amontoison amontoison commented Jan 12, 2024

close #182.

@amontoison amontoison changed the title Try to not compile ssids on some compilers Update continuous integration Jan 12, 2024
@nimgould
Copy link
Contributor

Just to mention that I tried ssids (galahad version) with the nvidia suite, and I can't compile one of the gpu codes (internal compiler error). However, compiling with cuda_nocuda.F90 instead of cuda.F90 (i.e, turn off GPU support) compiles and runs fine. Thus, for the time being, we should do thsi (and the archdefs system has been modified accordingly)

@amontoison
Copy link
Member Author

Just to mention that I tried ssids (galahad version) with the nvidia suite, and I can't compile one of the gpu codes (internal compiler error). However, compiling with cuda_nocuda.F90 instead of cuda.F90 (i.e, turn off GPU support) compiles and runs fine. Thus, for the time being, we should do thsi (and the archdefs system has been modified accordingly)

I opened a PR in the GitHub repository of SPRAL to test it with nvidia compilers.
I have a similar compiler error than icpc...
ralna/spral#180

meson.build Outdated Show resolved Hide resolved
@amontoison
Copy link
Member Author

I was able to compile GALAHAD (without SSIDS) with the Intel compilers on Mac.
All tests passed 🎉
I also fixed a bunch of other details.
On Windows, I need to dig more to understand the issue with the Intel linker.

@amontoison amontoison merged commit cf8da09 into ralna:master Jan 13, 2024
6 of 12 checks passed
@amontoison amontoison deleted the ssids-compilers branch January 13, 2024 01:11
@nimgould
Copy link
Contributor

Very good. Do you know what the ssids issue is - what did the compiler grumble about?

@amontoison
Copy link
Member Author

Internal compiler error 20000:
https://github.com/ralna/spral/actions/runs/7505963818/job/20436349072#step:10:335
We have this error with all versions of icpc (Mac, Linux), and icl on Windows.
The new compiler Intel icx on Windows that compiles both C and C++ files also has this error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link with -lc++ instead of -lstdc++ on Mac and FreeBSD
2 participants