Improve cypress stability

[louise-davies]

Description

I noticed that some cypress tests were flaky due to failing in the beforeEach hook because I guess waiting for progress bar to appear then disappear could cause issues if the page loads too fast for cypress to see the progress bar? Now we just use another assert to check the page has loaded and check the progress bar is not visible, which I think should help stabilise these tests

Testing instructions

Add a set up instructions describing how the reviewer should test the code

• Review code
• Check Actions build
• Review changes to test coverage

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ff940e4) 94.99% compared to head (ca50ff2) 94.99%.
Report is 5 commits behind head on develop.

❗ Current head ca50ff2 differs from pull request most recent head 540ed21. Consider uploading reports for the commit 540ed21 to get more accurate results

Additional details and impacted files

@@           Coverage Diff            @@
##           develop     #315   +/-   ##
========================================
  Coverage    94.99%   94.99%           
========================================
  Files           76       76           
  Lines         3498     3498           
  Branches       968      968           
========================================
  Hits          3323     3323           
  Misses         173      173           
  Partials         2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kaperoo]

Looks good to me 👍