Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement NativeCall wide string support #3044

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Implement NativeCall wide string support #3044

wants to merge 14 commits into from

Conversation

Kaiepi
Copy link
Contributor

@Kaiepi Kaiepi commented Jul 11, 2019

This does two things, mainly:

  • implements support for wchar_t and wint_t, as well as C++'s char16_t and char32_t types. These are accurate on MoarVM, but may be unreliable on the JVM and JS backends.
  • implements wide string support for the P6str and CStr REPRs on MoarVM.

This needs testing on Windows.

Passes make test, make spectest on OpenBSD.

See MoarVM/MoarVM#1137 and Raku/nqp#564

Kaiepi added 14 commits July 11, 2019 04:02
@Kaiepi
Implement NativeCall support for wchar_t, wint_t, char16_t, char32_t
0b0878e
@Kaiepi
Implement iswcharunsigned/iswintunsigned ops
e2943e8
@Kaiepi
Silence warnings about wide string types
3bb0b36
@Kaiepi
Keep track of native types' ctypes
b7ee17c 
ctypes are now included when composing native types, so update their
corresponding metamodel to do so. This also adds a getter method to
Metamodel::NativeHOW for its ctype attribute.
@Kaiepi
Update metamodel info related to CStr and wide strings
d58b1b2
@Kaiepi
Add some NativeCall traits for use with wide strings
14ca1e2
@Kaiepi
Support using explicitly managed wide strings
a33b690
@Kaiepi
Fix native character type passing to REPR data
9266f23
@Kaiepi
Support using wide strings as attributes
3dca8ae
@Kaiepi
Small refactor to wide string handling
64c8e07
@Kaiepi
Fix explicitly-manage
2f5aceb
@Kaiepi
Unit test NativeCall wide string support
5015170
@Kaiepi
Pass native REPR types as nativetype, not type
e23536e 
"type" is mainly used for type names, not type constants.
@Kaiepi
Add WideStr, U16Str, U32Str types for cglobal/nativecast
4399b2e
@raiph
Copy link
Contributor

raiph commented Sep 6, 2019

Note https://stackoverflow.com/questions/57584155/how-to-properly-use-char-and-wchar-t-in-nativecall-perl6#comment101984459_57584155 response to your comment

@Kaiepi
Copy link
Contributor Author

Kaiepi commented May 28, 2020

Update on this: I do plan on completing this PR at some point, since I want editline support for the REPL eventually, but I've been caught up with the work for the IP6NS grant, among other things.

@lizmat
Copy link
Contributor

lizmat commented Jan 5, 2022

Is this PR still salvageable?

@coke coke changed the base branch from master to main April 19, 2023 15:33
@lizmat
Copy link
Contributor

lizmat commented Sep 29, 2024

It feels like all of Kaiepi's work will be lost unless someone reimagines this work.

@patrickbkr @timo @niner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kaiepi @raiph @lizmat