Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scgi_task: allow compiling when MSG_NOSIGNAL undefined #1328

Closed
wants to merge 1 commit into from

Conversation

barracuda156
Copy link

No description provided.

@barracuda156
Copy link
Author

Everything else works now without patching, this is the only issue:

rpc/scgi_task.cc: In member function 'virtual void rpc::SCgiTask::event_write()':
rpc/scgi_task.cc:203:60: error: 'MSG_NOSIGNAL' was not declared in this scope
  203 |   int bytes = ::send(m_fileDesc, m_position, m_bufferSize, MSG_NOSIGNAL);
      |                                                            ^~~~~~~~~~~~
make[2]: *** [rpc/scgi_task.o] Error 1

@rakshasa
Copy link
Owner

rakshasa commented Dec 5, 2024

This is an issue with your libcurl version or something, and that flag is vital.

@rakshasa rakshasa closed this Dec 5, 2024
@barracuda156
Copy link
Author

barracuda156 commented Dec 5, 2024

@rakshasa No, it is absent in the system. See, for example: lpeterse/haskell-socket#8
Solaris also does not have it.

Also: https://noahdesu.github.io/2014/01/16/port-sendmsg.html

Of course, if you can suggest a better fallback, it would be far better than defining it to zero.

@stickz
Copy link
Contributor

stickz commented Dec 5, 2024

@barracuda156 @rakshasa I have submitted #1329 with a proper fix. It will detect Apple or Solaris at compile time and only disable the flag for these platforms. It's undefined anyways, so it's not going to accomplish anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants