Replace usleep with C++11's sleep_for #201
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build failure seems unrelated. |
|
Rebased. |
usleep is deprecated and replaced by nanosleep in POSIX 2008. sleep_for is standard C++11 and internally uses nanosleep.
|
Add this as a member function to |
|
On further evaluation, these should use condition variables, no? |
uis246
reviewed
Mar 4, 2025
| @@ -60,7 +61,7 @@ thread_base::stop_thread_wait() { | |||
| release_global_lock(); | |||
|
|
|||
| while (!is_inactive()) { | |||
| usleep(1000); | |||
| std::this_thread::sleep_for(std::chrono::milliseconds(1)); | |||
There was a problem hiding this comment.
Looks like average thread join. Sleeping for join is anti-pattern in userspace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
usleep is deprecated and replaced by nanosleep in POSIX 2008.
sleep_for is standard C++11 and internally uses nanosleep.