Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added js directory #90

Conversation

siddharthgoel94
Copy link
Contributor

What does this PR do?

Added a directory named js to handle the javascript code seperately instead of writing it in directly in index.html file. This will make the code more readable and manageable. No changes done to the code inside the scripts, made 3 different javascript files as per the scripts written in index.html file

Type of change

  • Chore (refactoring code, technical debt, workflow improvements)

How should this be tested?

  • We can run the website directly to check if all functionalities are working fine.

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Copy link

netlify bot commented Oct 11, 2024

Deploy Preview for badge-website ready!

Name Link
🔨 Latest commit 02bc1e9
🔍 Latest deploy log https://app.netlify.com/sites/badge-website/deploys/6708d9f763c15d00084bdefd
😎 Deploy Preview https://deploy-preview-90--badge-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you @siddharthgoel94 for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. We appreciate your support in making this project better

@rajatrajputdev rajatrajputdev merged commit bb6e4ae into rajatrajputdev:main Oct 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants