Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the version of dartcv4 fixed (without ^) in opencv_core and … #325

Merged
merged 3 commits into from
Jan 20, 2025

Conversation

rainyl
Copy link
Owner

@rainyl rainyl commented Jan 20, 2025

fix: #323

make the version of dartcv4 fixed (without ^) in opencv_core and opencv_dart

@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.95%. Comparing base (38509a9) to head (c91f8b0).
Report is 6 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #325      +/-   ##
==========================================
+ Coverage   92.62%   92.95%   +0.33%     
==========================================
  Files          49       50       +1     
  Lines        9507    10582    +1075     
==========================================
+ Hits         8806     9837    +1031     
- Misses        701      745      +44     
Flag Coverage Δ
unittests 92.95% <ø> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -5,7 +5,7 @@ description: |
please use `opencv_core` instead.
version: 1.3.5
opencv_version: 4.11.0+0
dartcv_version: 4.11.0.0
dartcv_version: 4.11.0.1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't that be +1?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's correct. dartcv contains the C wrappers, since cocoapods doesn't allow such version number as 4.11.0+1, .1 was used.

@rainyl rainyl merged commit 3140bdc into main Jan 20, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use fixed dependency for opencv_core and opencv_dart
3 participants