-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Async Impl #101
Async Impl #101
Conversation
So it works, but just need to rewrite nearly every API. opencv_dart/example/lib/main.dart Lines 46 to 53 in 03ee7e6
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #101 +/- ##
==========================================
+ Coverage 90.36% 91.38% +1.02%
==========================================
Files 35 57 +22
Lines 5322 7828 +2506
==========================================
+ Hits 4809 7154 +2345
- Misses 513 674 +161 ☔ View full report in Codecov by Sentry. |
i just saw it, i will try to implement what i can and open a pr to this pr branch, can we spilt the modules so i handle some and you handle some to avoid we both implementing the same things? also whats the easiest module i can follow as a reference since this pr has the alot of changes, so an easy module to follow will be the best option |
Sure, just create a new branch from async branch
For now I just implemented calib3d and imgcodecs, I think imgcodecs is the easiest, just several API in it, but remember to take a loot at core/types.h, in which many basic definitions inside it. |
add svd async
@abdelaziz-mahdy I have added async version of SVD, hope you are not doing the same module, may I ask which module are you working (or planning working) on? Besides, if you finish some module, please open a PR to async branch. |
I think dnn or objdetect, and if I faced any problem will let you know For pr, deal will do so |
delete xdata of Mat
remove equatable
fix equatable
Contrib async
Fix getter setter, Clean code
@abdelaziz-mahdy I think it's time to merge, thanks for your efforts! |
Thank you for everything 💖 |
Tasks
callback
to existed functions or add new functions?new functions
, e.g.,CvStatus Mat_New_Async(MatCallback callback);
gapiTOD: too much works, add in the futurehighguibump opencv.full to 4.10.0+3