Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing default value support for field values #1380

Merged
merged 8 commits into from
Feb 24, 2025

Conversation

findolor
Copy link
Collaborator

Motivation

See issue: #1368

Solution

  • Add an optional default field to field value definitions in gui yaml
  • Update getAllFieldDefinitions function to work with default filter parameter
  • Update UI to show field definitions with default value under the advanced options section
  • Set input value to default value in field definition if default exist
  • During calldata generation, save default value if no input is entered by the user
  • Update tests

Checks

By submitting this for review, I'm confirming I've done the following:

  • made this PR as small as possible
  • unit-tested any new functionality
  • linked any relevant issues or PRs
  • included screenshots (if this involves a front-end change)

@findolor findolor added rust Related to rust crates webapp labels Feb 24, 2025
@findolor findolor requested a review from hardyjosh February 24, 2025 12:02
@findolor findolor self-assigned this Feb 24, 2025
@findolor findolor linked an issue Feb 24, 2025 that may be closed by this pull request
@hardyjosh hardyjosh enabled auto-merge February 24, 2025 21:20
@hardyjosh hardyjosh merged commit 5fcf74b into main Feb 24, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rust Related to rust crates webapp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ability to set defaults (not just presets)
2 participants