Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2025 02 21 fix missing logos #1366

Merged
merged 1 commit into from
Feb 21, 2025
Merged

2025 02 21 fix missing logos #1366

merged 1 commit into from
Feb 21, 2025

Conversation

rouzwelt
Copy link
Contributor

@rouzwelt rouzwelt commented Feb 21, 2025 •
edited
Loading

Motivation

fix missing logos

Solution

use logos from ui-components pkg

⚠️ do not merge before #1340 , and change base branch to main before merging

Checks

By submitting this for review, I'm confirming I've done the following:

  • made this PR as small as possible
  • unit-tested any new functionality
  • linked any relevant issues or PRs
  • included screenshots (if this involves a front-end change)

@rouzwelt rouzwelt changed the base branch from main to 2025-02-18-rm-typeshare February 21, 2025 05:21
@rouzwelt rouzwelt requested a review from hardyjosh February 21, 2025 05:21
@rouzwelt rouzwelt self-assigned this Feb 21, 2025
@rouzwelt rouzwelt added the bug Something isn't working label Feb 21, 2025
@findolor findolor linked an issue Feb 21, 2025 that may be closed by this pull request
Tauri app has missing logos #1365
Closed
@hardyjosh hardyjosh merged commit 587cc63 into 2025-02-18-rm-typeshare Feb 21, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardyjosh hardyjosh hardyjosh approved these changes

Assignees

@rouzwelt rouzwelt

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tauri app has missing logos
2 participants
@rouzwelt @hardyjosh