Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove calldata file in dotrain order and refactor order operations #1358

Merged
merged 7 commits into from
Feb 21, 2025

Conversation

findolor
Copy link
Collaborator

@findolor findolor commented Feb 19, 2025

Caution

DO NOT MERGE BEFORE #1357

I've accidentally pushed everything on top an existing PR so there are extra changes in state_management.rs. Please review this PR after merging that one.

Motivation

See issue: #1328

Solution

Checks

By submitting this for review, I'm confirming I've done the following:

  • made this PR as small as possible
  • unit-tested any new functionality
  • linked any relevant issues or PRs
  • included screenshots (if this involves a front-end change)

fix #1328

@findolor findolor requested a review from hardyjosh February 19, 2025 15:35
@findolor findolor self-assigned this Feb 19, 2025
@findolor findolor added the rust Related to rust crates label Feb 19, 2025
@findolor findolor changed the title 2025 02 19 order operations refactor Remove calldata file in dotrain order and refactor order operations Feb 19, 2025
@findolor findolor merged commit a7ea9ed into main Feb 21, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rust Related to rust crates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move calldata generation functions out of dotrain order
2 participants