2024-07-25-constants-for-testing #23
Closed
+19
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedavidmeister
requested changes
Jul 30, 2024
| import "openzeppelin-contracts/contracts/utils/introspection/IERC1820Registry.sol"; | ||
|
|
||
| /// @dev https://eips.ethereum.org/EIPS/eip-1820#single-use-registry-deployment-account | ||
| IERC1820Registry constant IERC1820_REGISTRY = IERC1820Registry(0x1820a4B7618BdE71Dce8cdc73aAB6C95905faD24); |
There was a problem hiding this comment.
this is actually already in the rain.erc1820 repo https://github.com/rainlanguage/rain.erc1820/blob/main/src/lib/LibIERC1820.sol#L7
| // SPDX-License-Identifier: CAL | ||
| pragma solidity ^0.8.18; | ||
|
|
||
| import "openzeppelin-contracts/contracts/utils/introspection/IERC1820Registry.sol"; |
There was a problem hiding this comment.
| /// @dev Stub expression bytecode used for testing purposes. | ||
| /// This is a simple bytecode stub that can be used as a placeholder for | ||
| /// expressions with mock initialization in tests. The bytecode is arbitrary | ||
| bytes constant STUB_EXPRESSION_BYTECODE = hex"010000"; |
There was a problem hiding this comment.
maybe we should put abstract stuff for mocking and testing the interpreter in the interpreter interface repo under test/abstract
https://github.com/rainlanguage/rain.interpreter.interface/tree/main/test/abstract
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Constants are needed to transfer test cases and mock libraries from the legacy repository.
Solution
Added a file with constants necessary for the implementation of the test cases.
Checks
By submitting this for review, I'm confirming I've done the following: