Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maxInput headroom #288

Merged
merged 3 commits into from
Jan 1, 2025
Merged

maxInput headroom #288

merged 3 commits into from
Jan 1, 2025

Conversation

rouzwelt
Copy link
Collaborator

@rouzwelt rouzwelt commented Dec 28, 2024 •
edited
Loading

Motivation

resolves #287

Solution

add some headroom for maxInput of arb3() to account for the difference

Checks

By submitting this for review, I'm confirming I've done the following:

  • made this PR as small as possible
  • unit-tested any new functionality
  • linked any relevant issues or PRs
  • included screenshots (if this involves a front-end change)

@rouzwelt rouzwelt added bug Something isn't working enhancement New feature or request labels Dec 28, 2024
@rouzwelt rouzwelt self-assigned this Dec 28, 2024
hardyjosh
hardyjosh reviewed Dec 30, 2024
View reviewed changes
Copy link
Contributor

@hardyjosh hardyjosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the headroom be configurable? Where is the data showing 10% as the ideal amount?

@rouzwelt rouzwelt merged commit 912d4c3 into master Jan 1, 2025
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardyjosh hardyjosh hardyjosh approved these changes

@thedavidmeister thedavidmeister Awaiting requested review from thedavidmeister

Assignees

@rouzwelt rouzwelt

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add headroom for arb3() maxInput
2 participants
@rouzwelt @hardyjosh