Use for await in install function #1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using ncu within a script (top level function with `"type": "module"`) with always install option, it doesn't actually run the install command after upgrading `package.json`
```
const upgraded = await ncu.run({
upgrade: true,
install: "always",
});
console.log("upgraded", upgraded); // { "mypackage": "^2.0.0", ... }
process.exit(0);
```
I debugged through `node_modules/npm-check-updates/build/index.js`, I can see the function within `forEach` (https://github.com/raineorshine/npm-check-updates/blob/b7c3106c9b1ba96608165f808dcd726ba76286bc/src/index.ts#L148) is getting called. So I suspect the whole `install` function is not properly getting awaited.
The part I don't quite understand is why running directly through `npx` works fine, maybe due to the `cli` scripts are wrapped in iife and vite bundled it in a smarter way?
MacOS, node - v20.13.1
raineorshine
approved these changes
Nov 3, 2024
|
Tried with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using ncu within a script (top level function with
"type": "module") with always install option, it doesn't actually run the install command after upgradingpackage.jsonI debugged through
node_modules/npm-check-updates/build/index.js, I can see the function withinforEach(npm-check-updates/src/index.ts
Line 148 in b7c3106
installfunction is not properly getting awaited.The part I don't quite understand is why running directly through
npxworks fine, maybe due to thecliscripts are wrapped in iife and vite bundled it in a smarter way?MacOS, node - v20.13.1