Refactor .ncurc loading

[jftanner]

My primary intent here was to fix #1452. Internally, format is expected to be an array. However, when it's loaded outside the cli (in runUpgrades) it's not parsed as such. The correct answer probably would have been to validate it and throw an error. However, since even this repo's own .ncurc file uses a string, that would definitely be a breaking change.

While this fixes the problem, I recommend refactoring the app to validate the loaded .ncurc file every time one is loaded, and avoid passing into commander as arguments. There remain a number of type-safety issues with invalid configs that are outside the scope of this PR.

The code to set args didn't need to change, but I'd already cleaned it up while chasing a red herring, so I figured I'd leave it.

I didn't see commit guidelines anywhere, but let me know if you'd prefer a semantic-commit format and I can change it.

Oh, and thanks for this incredibly helpful tool!

[jftanner]

Ah... the tests run against build. :(
I'm used to using tsx to run typescript directly, so I didn't even think to build it before testing.
I'll need to debug this over the weekend.

[jftanner]

It's because I was setting { format: undefined }. :)

[raineorshine]

Thanks, looks good!

While this fixes the problem, I recommend refactoring the app to validate the loaded .ncurc file every time one is loaded, and avoid passing into commander as arguments. There remain a number of type-safety issues with invalid configs that are outside the scope of this PR.

Yes, good point.

Ah... the tests run against build. :(
I'm used to using tsx to run typescript directly, so I didn't even think to build it before testing.

That's not a great test setup on my part. npm test should not depend on anything other than dependencies being installed to work!