Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add installedVersion format option #1449

Conversation

jakubdrozdek
Copy link
Contributor

@jakubdrozdek jakubdrozdek commented Aug 21, 2024

A new format option called exactCurrentVersion has been added. This option replaces the usual version range copied from the project's package.json file with the exact version of the installed package. For instance, this feature might be helpful if you need to generate a release changelog gist for the updated package.

@jakubdrozdek jakubdrozdek marked this pull request as draft August 21, 2024 13:10
@jakubdrozdek
Copy link
Contributor Author

jakubdrozdek commented Aug 21, 2024

@raineorshine Seems like the tests for getIgnoredUpgradesDueToEnginesNode rely on the actual data returned from the NPM registry, and are flaky - if you'd run them again in a month, they might fail with no changes in the code.

@jakubdrozdek jakubdrozdek marked this pull request as ready for review August 21, 2024 13:29
Copy link
Owner

@raineorshine raineorshine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new format option called exactCurrentVersion has been added. This option replaces the usual version range copied from the project's package.json file with the exact version of the installed package. For instance, this feature might be helpful if you need to generate a release changelog gist for the updated package.

Thanks! Let's rename this to installedVersion if you don't mind. It's shorter and it makes it clear that this feature depends on the installed packages in node_modules, which not every package manager supports.

@raineorshine Seems like the tests for getIgnoredUpgradesDueToEnginesNode rely on the actual data returned from the NPM registry, and are flaky - if you'd run them again in a month, they might fail with no changes in the code.

Thanks for bringing this to my attention. We should definitely mock those requests.

@jakubdrozdek jakubdrozdek changed the title Add exactCurrentVersion format option Add installedVersion format option Aug 21, 2024
@raineorshine raineorshine merged commit a6f96a4 into raineorshine:main Aug 21, 2024
7 checks passed
@jakubdrozdek jakubdrozdek deleted the add-exactCurrentVersion-format-option branch August 21, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants