-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade SDK v.2.0 [BC BREAK] #27
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inbox ID at the client level
VladimirTaytor
approved these changes
Jul 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Integration between products is seamless right now 🎖️
IgorDobryn
approved these changes
Jul 5, 2024
mklocek
approved these changes
Jul 5, 2024
Co-authored-by: Ihor Dobryn <[email protected]>
Co-authored-by: Marcin Klocek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Make a similar architecture with other libraries.
Add a layer for quick creation of email client depending on parameters
Add native support for adding a template and its variables
Changes
MailtrapClient::initSendingEmails()
Emails
layers to use the inbox ID at the client level + testsProjects
&Messages
&Attachments
&Inboxes
layers + testsAccounts
&Permissions
&Users
layers + testsHow to test
OR install and run some examples from the new version of library