Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add FDL order type #163

Merged
merged 2 commits into from
Dec 31, 2024
Merged

Conversation

frantisekrokusek
Copy link
Contributor

@frantisekrokusek frantisekrokusek commented Dec 16, 2024

FDL is the standard download file order in EBICS 2.5

@frantisekrokusek frantisekrokusek changed the title add fdl order type add FDL order type Dec 16, 2024
@frantisekrokusek
Copy link
Contributor Author

@tobischo Here is the PR for the FDL order type.
Thanks for your review 🙏

@tobischo
Copy link
Collaborator

Thank you for splitting it up.
Do you happen to have some documentation on the FDL order type that I can refer to when checking this?

@tobischo
Copy link
Collaborator

https://www.ibm.com/docs/en/b2b-integrator/6.1.1?topic=types-fdl-order-type

Found this as a description of the FDL order type

@frantisekrokusek
Copy link
Contributor Author

You can find the specifications in the 2.5 final specifications chapter 9.6 Diagram 103
You have the definition in the XSD files in your specs or here under H004 specs
EBICS_Specification_2.5_final-16-05-2011.pdf
image

@tobischo
Copy link
Collaborator

tobischo commented Dec 18, 2024

Thanks 😄 I should have checked the general EBICS spec. I am so used to some banks/countries having their own flavors and not everyone supporting everything that I didn't even consider it.
This helps and got me to the question I was pondering about when just looking at the code.

Shouldn't we include from/to as optional values to be passed, since a date range can be provided?

@frantisekrokusek
Copy link
Contributor Author

Indeed I will add those optional fields!

@frantisekrokusek
Copy link
Contributor Author

@tobischo it's ready 🙏 Have nice last day of the year!

@tobischo tobischo merged commit 120de6d into railslove:master Dec 31, 2024
@tobischo tobischo self-assigned this Dec 31, 2024
@tobischo tobischo self-requested a review December 31, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants