-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
H003 schematic support #154
base: master
Are you sure you want to change the base?
Conversation
Hi @tobischo, |
I am really excited to see that you also added EBICS 3 🤩 I had that on my list as a potential followup after your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks great.
I haven't tested it yet against an EBICS API, so I cannot speak to whether it is still working (yet).
I think it is missing some test cases, e.g. around the signature algorithm handling and using a different EBICS version
@@ -6,7 +6,7 @@ | |||
EPICS is a ruby implementation of the [EBICS](https://www.ebics.org/) (Electronic Banking Internet | |||
Communication Standard). | |||
|
|||
It supports EBICS 2.5. | |||
It supports EBICS 2.4, 2.5 and 3.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the readme could reflect which one is the default when initializing a new or existing client and how to work with another version
@jplot do you need help finalizing this ? |
No description provided.