Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rails release details to the rails releases table #89

Merged
merged 4 commits into from
Oct 1, 2024

Conversation

etagwerker
Copy link
Member

@etagwerker etagwerker commented Sep 30, 2024

Hi there,

This will make it easier to set up GitHub Actions based on the right version numbers. I'm trying to get this in the main branch so that later I can use it in #84

Most of the information came from these resources:

Please check it out.

Thanks!

Copy link

@gdiaz-ol gdiaz-ol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a small question/suggestion.

end

desc "Update minimum Ruby versions from Rails 2.3 to 7.2"
task update_rails_releases: :environment do

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would make sense to add find_or_create_rails_releases as prerequisites task after environment ?

@etagwerker
Copy link
Member Author

@gdiaz-ol I just updated the PR with your feedback. Please take another look. Thanks!

@etagwerker etagwerker merged commit 1f76df2 into main Oct 1, 2024
1 check passed
@etagwerker etagwerker deleted the feature/more-granular-rails-release-data branch October 1, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants