Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the return value from the command to determine exit code #522

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Use the return value from the command to determine exit code #522

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c2f5dd
Use the return value from the command to determine exit code
dkniffin Aug 15, 2016
88cdc7b
Merge branch 'master' into feature/exit-nonzero-on-falsey-return-value
dkniffin Jan 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/thor/base.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,7 +463,10 @@ def namespace(name = nil)
#
def start(given_args = ARGV, config = {})
config[:shell] ||= Thor::Base.shell.new
dispatch(nil, given_args.dup, nil, config)
command_return = dispatch(nil, given_args.dup, nil, config)

# Use the return value from the command to determine exit code
exit(1) unless command_return
rescue Thor::Error => e
config[:debug] || ENV["THOR_DEBUG"] == "1" ? (raise e) : config[:shell].error(e.message)
exit(1) if exit_on_failure?
Expand Down