Use a dedicated ActiveSupport::Deprecation

[etiennebarrie]

Rails 7.1 will deprecate using the singleton ActiveSupport::Deprecation instance (rails/rails#47354). This defines one for the gem and uses it.

It's also added to the application's set of deprecators, allowing it to be configured along all the other deprecators.

cc @rafaelfranca

[skipkayhil]

One comment, otherwise looks good to me!

[skipkayhil]

Suggested change

	initializer :deprecator do |app|
	initializer "sprockets-rails.deprecator" do |app|

While the other initializers here don't do this (and probably never will due to backwards incompatibility), I think any new initializers added should be namespaced so that they don't conflict with any other gems.

(Duplicate initializer names has been a problem before: rails/rails#43261 (comment))

[etiennebarrie]

Hum there's already a namespace in the sense that all initializers are defined within a Railtie.

$ bin/rails initializers | grep deprecator
Sprockets::Railtie.deprecator

(Rails 7.0 app running with this branch)

It feels like the issue you're mentioning is more a bug/misfeature in Railtie::Initializable but OK.

I see all the other deprecators have a namespace in their initializer's name so that makes sense.

[ghiculescu]

Could we get this included in a release please?

[klyonrad]

This change causes an exception when we try to initialize our Rails 7.1 app

gems/sprockets-rails-3.5.0/lib/sprockets/railtie.rb:129:in `block in <class:Railtie>': undefined method `deprecator' for Sprockets::Rails:Module (NoMethodError)

      app.deprecators[:sprockets_rails] = Sprockets::Rails.deprecator if app.respond_to?(:deprecators)

what could we do to fix that?

[etiennebarrie]

What do you mean by initialize your app?
I can't reproduce with a brand new Rails 7.1 app with sprockets-rails 3.5.0, I'm able to boot the application and precompile assets.

Can you share a backtrace or a repro script?

[fa11enangel]

This change causes an exception when we try to initialize our Rails 7.1 app

gems/sprockets-rails-3.5.0/lib/sprockets/railtie.rb:129:in `block in <class:Railtie>': undefined method `deprecator' for Sprockets::Rails:Module (NoMethodError)

      app.deprecators[:sprockets_rails] = Sprockets::Rails.deprecator if app.respond_to?(:deprecators)

what could we do to fix that?

Maybe it is solved by newer version, see #525

[etiennebarrie]

Ok sorry about that (#524), it seems Rails itself used to require sprockets/railtie directly before 7.0 in config/application.rb via rails/all or more importantly directly if not all frameworks were loaded.

So there can be a lot of apps that directly require sprockets/railtie without loading sprockets-rails.

Similarly if you use only sassc-rails in your Gemfile, only the railtie is loaded:
https://github.com/sass/sassc-rails/blob/v2.1.2/lib/sassc/rails/railtie.rb#L4

I've opened #527 to make sure this doesn't happen again.