Simplify upgrade instructions in post_install_message
#469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mjankowski, now it might be the moment to remove it, yeah, but it's so verbose because people would ignore it and run into all sorts of problems when upgrading from < 0.8. It's been a while, so yeah, it should be fine I hope. In my short experience, people don't read the release notes, the changelog or review anything upstream before upgrading, so it's better to be as loud as possible 😅 🤷 |
rosa
reviewed
Dec 27, 2024
mjankowski
force-pushed
the
gemspec-upgrade-reduce
branch
from
b61c4eb to
9d31f06
Compare
|
Thank you so much, @mjankowski! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This message is sort of long, and it seems unlikely that people who are upgrading are not upgrading all the way to latest?
I'd probably just remove this entirely (in favour of release notes, changelogs, upgraders reviewing upstream first, etc) but short of that, maybe reduce length...?