Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ActionController::Caching::Sweeper class thread safe #72

Merged
merged 4 commits into from
Jun 29, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ source 'https://rubygems.org'

# Specify your gem's dependencies in active_record-observers.gemspec
gemspec
gem "minitest", "~> 5.8.4"
gem 'rails', github: 'rails/rails', branch: '5-1-stable'
gem 'activeresource', github: 'rails/activeresource'

Expand Down
1 change: 1 addition & 0 deletions gemfiles/rails_4_2.gemfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
source "https://rubygems.org"

gem "mocha", require: false
gem "minitest", "~> 5.8.4"
gem "rails", "~> 4.2.0"

gemspec path: "../"
1 change: 1 addition & 0 deletions gemfiles/rails_5_0.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ source "https://rubygems.org"

# Specify your gem"s dependencies in active_record-observers.gemspec
gem "rails", github: "rails/rails", branch: "5-0-stable"
gem "minitest", "~> 5.8.4"
gem "activeresource", github: "rails/activeresource"

gem "mocha", require: false
Expand Down
1 change: 1 addition & 0 deletions gemfiles/rails_master.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ source "https://rubygems.org"

# Specify your gem"s dependencies in active_record-observers.gemspec
gem "rails", github: "rails/rails"
gem "minitest", "~> 5.8.4"
gem "activeresource", github: "rails/activeresource"

gem "mocha", require: false
Expand Down
20 changes: 15 additions & 5 deletions lib/rails/observers/action_controller/caching/sweeper.rb
Original file line number Diff line number Diff line change
@@ -1,11 +1,17 @@
module ActionController #:nodoc:
module Caching
class Sweeper < ActiveRecord::Observer #:nodoc:
attr_accessor :controller

def initialize(*args)
super
@controller = nil
self.controller = nil
end

def controller
Thread.current["observer:#{self.class.name}_controller"]
end

def controller=(controller)
Thread.current["observer:#{self.class.name}_controller"] = controller
end

def before(controller)
Expand Down Expand Up @@ -53,8 +59,12 @@ def callback(timing)
end

def method_missing(method, *arguments, &block)
return super unless @controller
@controller.__send__(method, *arguments, &block)
return super if controller.nil?
controller.__send__(method, *arguments, &block)
end

def respond_to_missing?(method, include_private = false)
(controller.present? && controller.respond_to?(method)) || super
end
end
end
Expand Down
2 changes: 1 addition & 1 deletion test/helper.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
require 'minitest/autorun'
require 'mocha/mini_test'
require 'mocha/minitest'
require 'active_record'
require 'rails'
require 'rails/observers/activerecord/active_record'
Expand Down