Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add assert_not_dom, refute_dom, assert_not_select, refute_select & refute_dom_equal #113

Conversation

joshuay03
Copy link
Contributor

Implements #112

@joshuay03 joshuay03 marked this pull request as draft December 13, 2023 11:37
@joshuay03 joshuay03 force-pushed the feature/refute-and-assert-not-for-dom-and-dom-equal branch 2 times, most recently from 41ec29f to 554399f Compare December 13, 2023 11:43
@joshuay03 joshuay03 marked this pull request as ready for review December 13, 2023 11:48
@joshuay03 joshuay03 force-pushed the feature/refute-and-assert-not-for-dom-and-dom-equal branch 3 times, most recently from 396ac4b to b7b3e3a Compare December 16, 2023 10:43
Copy link
Member

@flavorjones flavorjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Made one small change suggestion.

lib/rails/dom/testing/assertions/selector_assertions.rb Outdated Show resolved Hide resolved
@joshuay03 joshuay03 force-pushed the feature/refute-and-assert-not-for-dom-and-dom-equal branch from b7b3e3a to 3072966 Compare January 2, 2024 22:32
@flavorjones
Copy link
Member

@joshuay03 CI is failing for uninteresting reasons ... you can rebase off #114 if you like, that should fix it.

@rafaelfranca rafaelfranca merged commit 5fd54c2 into rails:main Jan 3, 2024
24 of 26 checks passed
@joshuay03 joshuay03 deleted the feature/refute-and-assert-not-for-dom-and-dom-equal branch January 3, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants