Fixed helper splat warning due to being interpreted as argument prefix #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Necessary to resolve the following warnings showing up when using this gem in test suites with Ruby warnings enabled (i.e. `ruby -w`): `gems/propshaft-0.8.0/lib/propshaft/helper.rb:10: warning: *' interpreted as argument prefix`. By using parenthesis, these warnings go away and the test suite output is much cleaner.
|
Closing due to lack of feedback. Going to use a alternative solution instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Hello. 👋 Was seeing warnings show up in my test suite, since I have Ruby warnings enabled, and wanted to fix the issue in in this gem.
Details
Necessary to resolve the following warnings showing up when using this gem in test suites with Ruby warnings enabled (i.e.
ruby -w):gems/propshaft-0.8.0/lib/propshaft/helper.rb:10: warning: *' interpreted as argument prefix. By using parenthesis, these warnings go away and the test suite output is much cleaner.Notes
Not sure when you plan to publish a new version of this gem but if a patch release is acceptable, that would be most welcome. 🙇