Maintain sourcemap file extensions #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regular expression for generating digested paths in propshaft is updated to accommodate sourcemap files too. This will ensure the digested sourcemaps end `-sha.ext.map` instead of `ext-sha.map`. Services like Datadog that allow sourcemap uploads look specifically for files ending with `.js.map`, so this change allows compatibility. A corresponding test has been added in asset_test.rb, verifying that sourcemap files are correctly digesting their paths.
|
Looks good, can you resolve the conflicts Github is complaning so we can merge please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regular expression for generating digested paths in propshaft is updated to accommodate sourcemap files. This will ensure the digested sourcemaps end
-sha.ext.mapinstead ofext-sha.map. Services like Datadog that allow sourcemap uploads look specifically for files ending with.js.map, so this change allows compatibility. A corresponding test has been added in asset_test.rb, verifying that sourcemap files are correctly digesting their paths.