Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in upgrade guide #149

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Fix typo in upgrade guide #149

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions UPGRADING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ After you are done you will notice that the install step added various files to

The `./bin/dev` file is a shell script that uses [foreman](https://github.com/ddollar/foreman) and `Procfile.dev` to start two processes in a single terminal: `rails s` and `yarn build`. The latter replaces `webpack-dev-server` for bundling and watching for changes in javascript files.

**The 'build' attribute added to packages.json**
**The 'build' attribute added to package.json**

This is the command that `yarn build` will use to bundle javascript files.

Expand Down Expand Up @@ -63,7 +63,7 @@ module.exports = {
}
```

Then open `packages.json` and add this:
Then open `package.json` and add this:
```json
"babel": {
"presets": [
Expand All @@ -72,7 +72,7 @@ Then open `packages.json` and add this:
}
```

Finally, download [webpackers babel preset](https://github.com/rails/webpacker/blob/master/package/babel/preset.js) file and place it in the same directory as `packages.json` with the name `webpack.babel.js`.
Finally, download [webpackers babel preset](https://github.com/rails/webpacker/blob/master/package/babel/preset.js) file and place it in the same directory as `package.json` with the name `webpack.babel.js`.

**Module resolution**

Expand Down Expand Up @@ -157,7 +157,7 @@ After you are done you will notice that the install step updated some files.

Just like the javascript process, this one will bundle and watch for changes in css files.

**The 'build:css' attribute added to packages.json**
**The 'build:css' attribute added to package.json**

This is the command `yarn build` will use to bundle css files.

Expand Down Expand Up @@ -191,7 +191,7 @@ stylesheets/sources/application/source_1.scss
stylesheets/sources/application/source_2.scss
```

Then adjust the `build` attribute in `packages.json`:
Then adjust the `build` attribute in `package.json`:
```
"build:css": "sass ./app/assets/stylesheets/entrypoints:./app/assets/builds --no-source-map --load-path=node_modules"
```
Expand Down