Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remake pagination component #210

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MacLove13
Copy link

Redesigned the pagination component to display it in a simpler way and with the option for the user to navigate to:

  • Next page
  • Previous page
  • First page
  • Last page

Covering changes in component display behavior depending on which page the user is on, for example, close to the first or last page and when on the first or last page.

Screens:
image

image image image image image

@MacLove13
Copy link
Author

As it is a completely new component, I ended up recreating the tests on it and checking yet another new scenario, that of displaying the number of the last page.
@rosa ready for review ;)

@ibrahima
Copy link

I don't want to put pressure on anyone, and I appreciate everyone's hard work on this gem, but it would make me exceedingly happy if this were to go into a future release. It can be quite difficult to navigate to recent jobs since the failed jobs are currently sorted in ascending order, so to get to recent jobs I often end up having to edit the page number in the URL because there's no way to get to the last page easily. Perhaps the intention is that you should clear failed jobs periodically but if that's not done regularly it can get out of hand. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants