Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ignoring nil values in Jbuilder scope #580

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

moritonal
Copy link

Okay, this isn't clear to merge yet. I'm doing this to see how the Actions run because I think there's currently a bug in it's building.

@moritonal
Copy link
Author

Okay, so it's not just me, the actions are all failing on

/home/runner/work/jbuilder/jbuilder/vendor/bundle/ruby/3.0.0/gems/activesupport-7.0.8.7/lib/active_support/logger_thread_safe_level.rb:12:in `<module:LoggerThreadSafeLevel>': uninitialized constant ActiveSupport::LoggerThreadSafeLevel::Logger (NameError)
	from /home/runner/work/jbuilder/jbuilder/vendor/bundle/ruby/3.0.0/gems/activesupport-7.0.8.7/lib/active_support/logger_thread_safe_level.rb:9:in `<module:ActiveSupport>'

@moritonal
Copy link
Author

Okay, Ruby isn't my primary language so any advice is welcome on how to improve this. But it should fix up the issue whereby nested null's aren't processed correctly.

@moritonal
Copy link
Author

Attempts to solve #363

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant