Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache root #370

Merged
merged 8 commits into from
Nov 28, 2016
Merged

Cache root #370

merged 8 commits into from
Nov 28, 2016

Conversation

dhh
Copy link
Member

@dhh dhh commented Nov 15, 2016

Optimization technique extracted from Basecamp.

@dhh dhh merged commit 9f8694f into master Nov 28, 2016
@woodhull
Copy link

Why add this hack instead of accepting the PR that has a more elegant solution for all cases? See #298

Was there a problem with that PR's approach or anything someone interested in improving jbuilder cache performance generally might be able to contribute?

@dhh
Copy link
Member Author

dhh commented Dec 26, 2016

I didn't actually explore #298 in detail prior to this. Will have a look.

@kaspth kaspth deleted the cache-root branch January 3, 2017 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants