Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI for Rails 7.2 #187

Closed
wants to merge 1 commit into from
Closed

Add CI for Rails 7.2 #187

wants to merge 1 commit into from

Conversation

Earlopain
Copy link

Additionally, add an exclude for main since it bumped the ruby version

Additionally, add an exclude for main since it bumped the ruby version
@Earlopain
Copy link
Author

Earlopain commented Nov 1, 2024

Test failures seem somewhat legit, however I can't tell if tests are doing something wrong. Nobody complained about it in a real application yet probably:

# frozen_string_literal: true

require "bundler/inline"

gemfile(true) do
  source "https://rubygems.org"

  gem "activemodel", "~> 7.2.0"
  gem "railties", "~> 7.2.0"
  gem "activesupport", "~> 7.2.0"
end

require "rails"

module BlogApp
  class Application < Rails::Application; end
end
Rails.env = 'development'
app = BlogApp::Application.new
app.config.eager_load = true
app.initialize!
# /home/earlopain/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/railties-7.2.2/lib/rails/health_controller.rb:35:in `<module:Rails>': uninitialized constant ActionController::Base (NameError)
# 
#   class HealthController < ActionController::Base
#                                            ^^^^^^

Maybe because they are eager_autoloaded? rails/rails@b0b1eb5

@utkarsh2102
Copy link

@Earlopain, thanks for the patch, I wonder if it's safe to skip or ignore the above

uninitialized constant ActionController::Base (NameError)

error?

@Earlopain
Copy link
Author

I would guess it is test-only since I don't think anyone has reported it, so probably safe to ignore.

Anyways, I'll close this. Rails 8.0 has already been released and I don't have the motivation to dig into this.

@Earlopain Earlopain closed this Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants