Create workflow for testing for the ruby feature #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewn617
force-pushed
the
test-ruby-feature
branch
from
ad4c4e7
to
e3e0281
Compare
andrewn617
force-pushed
the
test-ruby-feature
branch
from
e3e0281
to
08d0ad2
Compare
This workflow spins up a devcontainer that uses the ruby feature and checks that ruby is installed.
andrewn617
force-pushed
the
test-ruby-feature
branch
from
08d0ad2
to
c2d0cbb
Compare
rafaelfranca
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a workflow for testing the ruby feature. I use the
devcontainer/cistep to create a devcontainer using the ruby feature and check that ruby is installed. I think that's sufficient for now.I am pushing the test image to
ghcr.io/rails/devcontainer/test-ruby-featureso it can be cached. Without a cache this workflow takes about ~10 minutes, about 6 of that is actually installing ruby, so the cache is quite helpful. I set this up to only push the image if it is frommain. We should make that package private probably.I created a link to the
featuresdirectory in the.github/.devcontainerdirectory (where the devcontainer used in the test lives). That way the local version of the feature can be used by the devcontainer. I tried to do this by mounting that folder in the devcontainer but it didn't seem to work 🤔 , so I went with the link instead.