Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use official HTTP mirrors instead of FTP for 1-stable #431

Open
wants to merge 2 commits into
base: 1-stable
Choose a base branch
from

Conversation

januszm
Copy link

@januszm januszm commented Feb 22, 2019

Related PR: #384

Change FreeTDS source server from FTP to HTTP

@januszm
Copy link
Author

januszm commented Feb 22, 2019

It'd be great if one of the maintainers could have a look at failing specs. Looks like the test MSSQL server is not available?

@wpolicarpo
Copy link
Member

@metaskills can you have a look here? I'm not sure if you want maintain 1.3.x given you decided to remove freetds installation from the gem itself (which I agree).

@aharpervc
Copy link
Contributor

The http archive goes down all the time as well, unfortunately (doesn't mean we shouldn't merge this, just fyi)

@januszm
Copy link
Author

januszm commented Feb 25, 2019

Can't we upload source files to a more reliable cloud storage or CDN? (e.g. Amazon S3, CloudFront) ?

@wpolicarpo
Copy link
Member

We can, but there are many problems with this approach:

  1. Security: How to guarantee the integrity of downloaded file if we host it somewhere?
  2. Cost: After all, someone would need to pay for it.
  3. Maintainers would have to monitor/maintain another source of artifacts

I personally don't see any issues in merging this, but I don't think it will solve the main issue, which is managing external dependencies and probably that's why they changed it in 2.x.

In my opinion, installing freetds should be a step of your deploy. It's more secure and reliable if we do that by ourselves than delegating this to a gem installation.

@januszm
Copy link
Author

januszm commented Feb 25, 2019

@wpolicarpo

In my opinion, installing freetds should be a step of your deploy. It's more secure and reliable if we do that by ourselves than delegating this to a gem installation.

I can not agree more, but it's not always easily available on certain Linux distributions, and this mechanism of downloading and installing freetds is just a nice "emergency" mechanism.

This still does not seem like a fully reliable solution, but, you know what they say: "something is better than nothing".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants