Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes active? method exception #708

Closed
wants to merge 1 commit into from
Closed

Fixes active? method exception #708

wants to merge 1 commit into from

Conversation

bendangelo
Copy link

For context. #707

Svelix
Svelix reviewed Dec 17, 2019
View reviewed changes
Copy link

@Svelix Svelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this now execute every query twice?

@aharpervc
Copy link
Contributor

If this is a problem with TinyTDS, then we should almost certainly be making this change in that repo rather than at this higher level

@bendangelo
Copy link
Author

Ok thank you. Yes this Pr has other side effects. Will close

@bendangelo bendangelo closed this Jan 3, 2020
@bendangelo bendangelo deleted the active-patch branch January 3, 2020 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Svelix Svelix Svelix left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bendangelo @aharpervc @Svelix