Removed old implementation of property injection (inversify#337)

ragnarol · Aug 10, 2016 · 9f19a82 · 9f19a82
1 parent 03b3451
commit 9f19a82
Show file tree

Hide file tree

Showing 6 changed files with 93 additions and 616 deletions.
diff --git a/src/annotation/property_injectors.ts b/src/annotation/property_injectors.ts
diff --git a/src/inversify.ts b/src/inversify.ts
@@ -15,12 +15,6 @@ import targetName from "./annotation/target_name";
 import { decorate } from "./annotation/decorator_utils";
 import { traverseAncerstors, taggedConstraint, namedConstraint, typeConstraint } from "./syntax/constraint_helpers";
 import guid from "./utils/guid";
-import {
-    makePropertyInjectDecorator,
-    makePropertyMultiInjectDecorator,
-    makePropertyInjectTaggedDecorator,
-    makePropertyInjectNamedDecorator
-} from "./annotation/property_injectors";
 
 export { Kernel };
 export { KernelModule };
@@ -30,10 +24,6 @@ export { tagged };
 export { named };
 export { inject };
 export { unmanaged };
-export { makePropertyInjectDecorator };
-export { makePropertyMultiInjectDecorator };
-export { makePropertyInjectTaggedDecorator };
-export { makePropertyInjectNamedDecorator };
 export { multiInject };
 export { targetName };
 export { traverseAncerstors };

diff --git a/test/annotation/property_injectors.test.ts b/test/annotation/property_injectors.test.ts
diff --git a/test/bugs/bugs.test.ts b/test/bugs/bugs.test.ts
@@ -5,8 +5,7 @@ import {
     Kernel,
     injectable,
     named,
-    inject,
-    makePropertyInjectNamedDecorator
+    inject
 } from "../../src/inversify";
 
 describe("Bugs", () => {
@@ -65,42 +64,6 @@ describe("Bugs", () => {
 
     });
 
-    it("Should not throw when args length of base and derived class match (property injection)", () => {
-
-        let kernel = new Kernel();
-        let injectNamed = makePropertyInjectNamedDecorator(kernel);
-
-        @injectable()
-        class Warrior {
-            protected rank: string;
-            public constructor() { // length = 0
-            }
-        }
-
-        let TYPES = { Rank: "Rank" };
-
-        @injectable()
-        class SamuraiMaster extends Warrior  {
-
-            @injectNamed(TYPES.Rank, "master")
-            @named("master")
-            protected rank: string;
-
-            public constructor() { // length = 0
-                super();
-            }
-        }
-
-        kernel.bind<SamuraiMaster>(SamuraiMaster).to(SamuraiMaster);
-        kernel.bind<string>(TYPES.Rank)
-            .toConstantValue("master")
-            .whenTargetNamed("master");
-
-        let master: any = kernel.get<SamuraiMaster>(SamuraiMaster);
-        expect(master.rank).eql("master");
-
-    });
-
     it("Should not throw when args length of base and derived class match (inject into the derived class)", () => {
 
         @injectable()