More dialog cleanup

rage · Jan 21, 2025 · 3a13831 · 3a13831
1 parent 8d7c986
commit 3a13831
Show file tree

Hide file tree

Showing 9 changed files with 15 additions and 9 deletions.
diff --git a/services/main-frontend/src/components/forms/NewReferenceForm.tsx b/services/main-frontend/src/components/forms/NewReferenceForm.tsx
@@ -91,12 +91,15 @@ const NewReferenceForm: React.FC<React.PropsWithChildren<NewReferenceFormProps>>
         </ErrorText>
       ))}
       <br />
-      <Button variant="primary" size="medium" type="submit" value={t("button-text-submit")}>
+      <Button
+        variant="primary"
+        size="medium"
+        fullWidth
+        type="submit"
+        value={t("button-text-submit")}
+      >
         {t("button-text-submit")}
       </Button>
-      <Button variant="secondary" size="medium" type="button" onClick={onCancel}>
-        {t("button-text-close")}
-      </Button>
     </form>
   )
 }

diff --git a/...src/components/page-specific/manage/courses/id/course-instances/NewCourseInstanceForm.tsx b/...src/components/page-specific/manage/courses/id/course-instances/NewCourseInstanceForm.tsx
@@ -104,12 +104,15 @@ const NewCourseInstanceForm: React.FC<React.PropsWithChildren<FormProps>> = ({
             margin-bottom: 0.5rem;
           `}
         />
-        <Button variant="primary" size="medium" type="submit" value={t("button-text-submit")}>
+        <Button
+          variant="primary"
+          size="medium"
+          fullWidth
+          type="submit"
+          value={t("button-text-submit")}
+        >
           {t("button-text-submit")}
         </Button>
-        <Button variant="secondary" size="medium" onClick={onCancel}>
-          {t("button-text-cancel")}
-        </Button>
       </form>
     </>
   )

diff --git a/...instance-management.spec.ts/initial-management-page-editing-desktop-regular.png b/...instance-management.spec.ts/initial-management-page-editing-desktop-regular.png
diff --git a/...rse-instance-management.spec.ts/initial-management-page-editing-mobile-tall.png b/...rse-instance-management.spec.ts/initial-management-page-editing-mobile-tall.png
diff --git a/...course-instance-management.spec.ts/new-course-instance-form-desktop-regular.png b/...course-instance-management.spec.ts/new-course-instance-form-desktop-regular.png
diff --git a/...ent/course-instance-management.spec.ts/new-course-instance-form-mobile-tall.png b/...ent/course-instance-management.spec.ts/new-course-instance-form-mobile-tall.png
diff --git a/...aterial-reference.spec.ts/add-new-material-reference-dialog-desktop-regular.png b/...aterial-reference.spec.ts/add-new-material-reference-dialog-desktop-regular.png
diff --git a/...__/material-reference.spec.ts/add-new-material-reference-dialog-mobile-tall.png b/...__/material-reference.spec.ts/add-new-material-reference-dialog-mobile-tall.png
diff --git a/system-tests/src/tests/material-reference.spec.ts b/system-tests/src/tests/material-reference.spec.ts
@@ -35,7 +35,7 @@ test("material reference tests", async ({ page, headless }, testInfo) => {
     headless,
     testInfo,
     snapshotName: "add-new-material-reference-dialog",
-    waitForTheseToBeVisibleAndStable: [page.getByText("Submit"), page.locator("text=Close")],
+    waitForTheseToBeVisibleAndStable: [page.getByText("Submit")],
   })
 
   await page.locator('textarea[name="references"]').click()