Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use StepRange rather than LinRange #429

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

rafaqz
Copy link
Owner

@rafaqz rafaqz commented Apr 21, 2023

Fixes #427

@biskwikman your example works for me on this branch, you can check it out with ] add Rasters#fix_lookup_accuracy if you would like to give it a try.

@rafaqz
Copy link
Owner Author

rafaqz commented Jun 28, 2023

Note: using step range is generally safer but has the small chance of complete failure even to load a raster if the length of the range is wrong due to floating point error.

Its not clear what kind of error is preferable, but not even loading a raster seems worse

@rafaqz
Copy link
Owner Author

rafaqz commented Oct 9, 2024

Further note: this will work if we use StepRangeLen, which didn't exist when Rasters.jl started but you get from range(; start, stop, length)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subsetting causes small errors in geographic extent
1 participant