Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix map mini piracy #958

Merged
merged 2 commits into from
Mar 26, 2025
Merged

Fix map mini piracy #958

merged 2 commits into from
Mar 26, 2025

Conversation

rafaqz
Copy link
Owner

@rafaqz rafaqz commented Mar 26, 2025

There was a tiny bit of piracy on map for both arrays and stacks.

Here fixed by removing the deprecated method, and the no args splat method for DimArray.

Piracy is now tested with Aqua.jl

@rafaqz rafaqz changed the title Fix map mini piracy Fix map mini piracy Mar 26, 2025
Copy link

codecov bot commented Mar 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.72%. Comparing base (0dfd00c) to head (450ce0e).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #958      +/-   ##
==========================================
+ Coverage   82.67%   82.72%   +0.04%     
==========================================
  Files          54       54              
  Lines        5150     5153       +3     
==========================================
+ Hits         4258     4263       +5     
+ Misses        892      890       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rafaqz rafaqz merged commit 863c696 into main Mar 26, 2025
9 of 10 checks passed
@rafaqz rafaqz deleted the fix_map_mini_piracy branch March 26, 2025 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant