Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid parser's blocks patterns #1882

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

rafalp
Copy link
Owner

@rafalp rafalp commented Feb 23, 2025

Adds test checking that block next to other block is parsed as two separate blocks, with extra logic for handling exceptions.

Also fixes lists parser because that one is very out of spec.

Fixes #1880

TODO

  • Fix lists parser
  • Fix tests other than blocks test
  • Add missing blocks to the test matrix
    • Indented code
    • Quote
    • Table

@rafalp rafalp added area: backend This issue involves Python, Django or dependency (eg. database) feature: parser Parser converts markdown/bbcode strings into other forms labels Feb 23, 2025
@rafalp rafalp added this to the Next feature release milestone Feb 23, 2025
@rafalp rafalp self-assigned this Feb 23, 2025
@rafalp rafalp force-pushed the fix-1880-cleanup-linebreak-in-patterns branch from 04046e0 to 842e1bc Compare February 25, 2025 20:34
@rafalp rafalp mentioned this pull request Feb 26, 2025
@coveralls
Copy link

coveralls commented Feb 27, 2025

Coverage Status

coverage: 97.164% (-0.009%) from 97.173%
when pulling 0dea95f on fix-1880-cleanup-linebreak-in-patterns
into 4d4b449 on main.

@rafalp rafalp force-pushed the fix-1880-cleanup-linebreak-in-patterns branch from 7a34766 to 1194859 Compare March 3, 2025 22:32
@rafalp rafalp force-pushed the fix-1880-cleanup-linebreak-in-patterns branch from 1194859 to 5fc23c6 Compare March 15, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: backend This issue involves Python, Django or dependency (eg. database) feature: parser Parser converts markdown/bbcode strings into other forms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate invalid \n|$ regex at end of parser's patterns
2 participants