add listen error functionality to listen async error from rabbus #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puellanivis
reviewed
Dec 19, 2018
| @@ -432,6 +434,7 @@ func (r *Rabbus) handleAmqpClose(err error) { | |||
| time.Sleep(time.Second) | |||
| aw, err := amqpwrap.New(r.config.dsn, r.config.passiveex) | |||
| if err != nil { | |||
| r.listenErrChan <- err | |||
There was a problem hiding this comment.
Each of these sends, needs to use the non-blocking version:
select {
case r.listenErrChan <- err:
default:
}Or else the first send that exceeds the buffer size will block forever, if no one is listening. This also means you can remove the buffer on the listenErrChan, but maybe it is nice to have a buffer like time.Timer has so that if the listener is busy when a second error is sent, it will not get dropped on the floor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in case of failed to reconnect, or some internal error on rabbus that happens asyncronously