Fixing an intermittent issue that happened when using spacebar to swi…

…tch checked/unchecked on Chrome.
rafael-trevisan · Feb 26, 2018 · cb7fa18 · cb7fa18
1 parent ba43f9b
commit cb7fa18
Show file tree

Hide file tree

Showing 6 changed files with 21 additions and 15 deletions.
diff --git a/apexplugin.json b/apexplugin.json
@@ -1,6 +1,6 @@
 {
   "name" : "IG Simple Checkbox",
-  "version" : "18.2.2",
+  "version" : "18.2.3",
   "description" : "This plug-in displays a single checkbox in Interactive Grids but allows you to set 2 values (one for checked and another for unchecked). It's perfect for Y(es)/N(o) or 1/0 type checkboxes.",
   "keywords" : ["checkbox", "ig", "simple"],
   "homepage" : "https://github.com/rafael-trevisan/apex-plugin-ig_simple_checkbox",

diff --git a/changelog.md b/changelog.md
@@ -1,5 +1,8 @@
 # Changelog
 
+## 18.2.3
+- Fixed an intermittent issue that happened when using spacebar to switch checked/unchecked on Chrome.
+
 ## 18.2.2
 - New feature [Issue #2](https://github.com/rafael-trevisan/apex-plugin-ig_simple_checkbox/issues/2)
 

diff --git a/dist/js/ca_trevis_apex_ig_simple_checkbox.bundle.min.js b/dist/js/ca_trevis_apex_ig_simple_checkbox.bundle.min.js
diff --git a/ig_simple_checkbox.sql b/ig_simple_checkbox.sql
@@ -30,6 +30,7 @@ wwv_flow_api.create_plugin(
 ,p_display_name=>'IG Simple Checkbox'
 ,p_supported_ui_types=>'DESKTOP'
 ,p_supported_component_types=>'APEX_APPL_PAGE_IG_COLUMNS'
+,p_image_prefix=>'&G_APEX_NITRO_IMAGES.'
 ,p_javascript_file_urls=>'#PLUGIN_FILES#js/ca_trevis_apex_ig_simple_checkbox.bundle.min.js'
 ,p_css_file_urls=>'#PLUGIN_FILES#css/ca_trevis_apex_ig_simple_checkbox.min.css'
 ,p_plsql_code=>wwv_flow_string.join(wwv_flow_t_varchar2(
@@ -118,7 +119,7 @@ wwv_flow_api.create_plugin(
 '          or (p_param.value is null and c_unchecked_value is null)',
 '         )',
 '  then',
-'    p_result.message := ''Checkbox contains invalid value!'';',
+'    p_result.message := ''Checkbox contains invalid value ('' || p_param.value || '')'';',
 '  end if;',
 'end validate_ig_simple_checkbox;',
 ''))
@@ -129,9 +130,9 @@ wwv_flow_api.create_plugin(
 ,p_standard_attributes=>'VISIBLE:SESSION_STATE:READONLY:SOURCE:ICON:ENCRYPT'
 ,p_substitute_attributes=>true
 ,p_subscribe_plugin_settings=>true
-,p_version_identifier=>'18.2.2'
+,p_version_identifier=>'18.2.3'
 ,p_about_url=>'https://github.com/rafael-trevisan/apex-plugin-ig_simple_checkbox'
-,p_files_version=>7
+,p_files_version=>9
 );
 wwv_flow_api.create_plugin_attribute(
  p_id=>wwv_flow_api.id(50145107408085211199)
@@ -232,15 +233,15 @@ wwv_flow_api.g_varchar2_table(28) := '65745265636F72642863292C693D652E696E746572
 wwv_flow_api.g_varchar2_table(29) := '6F7245616368282862293D3E7B695B625D2E656C656D656E7449643D3D3D612626286A3D62297D292C662E73657456616C756528682C6A2C672E76616C2829297D2C6B3D28293D3E7B636F6E737420613D682E66696E642827696E7075745B747970653D';
 wwv_flow_api.g_varchar2_table(30) := '22636865636B626F78225D27293B612E70726F702827636865636B6564272C672E76616C28293D3D3D63292C2828293D3E7B2428272E69672D73696D706C652D636865636B626F7827292E656163682828612C62293D3E7B242862292E706172656E7473';
 wwv_flow_api.g_varchar2_table(31) := '2827746427292E6F666628272E696773696D706C65636865636B626F7827292E6F6E28276B6579646F776E2E696773696D706C65636865636B626F78272C2861293D3E7B69662833323D3D3D612E7768696368297B636F6E737420613D242862292E6669';
-wwv_flow_api.g_varchar2_table(32) := '6E642827696E7075745B747970653D22636865636B626F78225D27293B672E76616C28612E70726F702827636865636B656427293F643A63292E6368616E676528292C6A2867292C6B28297D7D297D297D2928297D3B682E617070656E6428692829292C';
-wwv_flow_api.g_varchar2_table(33) := '682E66696E642827696E7075745B747970653D22636865636B626F78225D27292E6F6E28276368616E6765272C2861293D3E7B636F6E737420623D2428612E63757272656E74546172676574293B672E76616C28622E70726F702827636865636B656427';
-wwv_flow_api.g_varchar2_table(34) := '293F633A64292E6368616E676528292C6A2862292C672E666F63757328297D292C6B28292C622E726561644F6E6C79262628672E636C6F7365737428272E69672D73696D706C652D636865636B626F7827292E72656D6F7665436C617373282769672D73';
-wwv_flow_api.g_varchar2_table(35) := '696D706C652D636865636B626F782D64697361626C656427292C672E636C6F7365737428272E69672D73696D706C652D636865636B626F7827292E616464436C617373282769672D73696D706C652D636865636B626F782D656E61626C65642729292C61';
-wwv_flow_api.g_varchar2_table(36) := '7065782E6974656D2E63726561746528612C7B73657456616C75652861297B672E76616C2861292C6B28297D2C64697361626C6528297B672E636C6F7365737428272E69672D73696D706C652D636865636B626F7827292E616464436C61737328276967';
-wwv_flow_api.g_varchar2_table(37) := '2D73696D706C652D636865636B626F782D64697361626C656427292C672E636C6F7365737428272E69672D73696D706C652D636865636B626F7827292E72656D6F7665436C617373282769672D73696D706C652D636865636B626F782D656E61626C6564';
-wwv_flow_api.g_varchar2_table(38) := '27292C672E70726F70282764697361626C6564272C2130297D2C656E61626C6528297B622E726561644F6E6C797C7C28672E636C6F7365737428272E69672D73696D706C652D636865636B626F7827292E72656D6F7665436C617373282769672D73696D';
-wwv_flow_api.g_varchar2_table(39) := '706C652D636865636B626F782D64697361626C656427292C672E636C6F7365737428272E69672D73696D706C652D636865636B626F7827292E616464436C617373282769672D73696D706C652D636865636B626F782D656E61626C656427292C672E7072';
-wwv_flow_api.g_varchar2_table(40) := '6F70282764697361626C6564272C213129297D2C646973706C617956616C7565466F722861297B72657475726E20692821302C61297D7D297D7D5D293B0A';
+wwv_flow_api.g_varchar2_table(32) := '6E642827696E7075745B747970653D22636865636B626F78225D27293B72657475726E20672E76616C28612E70726F702827636865636B656427293F643A63292E6368616E676528292C6A2867292C6B28292C21317D72657475726E21307D297D297D29';
+wwv_flow_api.g_varchar2_table(33) := '28297D3B682E617070656E6428692829292C682E66696E642827696E7075745B747970653D22636865636B626F78225D27292E6F6E28276368616E6765272C2861293D3E7B636F6E737420623D2428612E63757272656E74546172676574293B672E7661';
+wwv_flow_api.g_varchar2_table(34) := '6C28622E70726F702827636865636B656427293F633A64292E6368616E676528292C6A2862292C672E666F63757328297D292C6B28292C622E726561644F6E6C79262628672E636C6F7365737428272E69672D73696D706C652D636865636B626F782729';
+wwv_flow_api.g_varchar2_table(35) := '2E72656D6F7665436C617373282769672D73696D706C652D636865636B626F782D64697361626C656427292C672E636C6F7365737428272E69672D73696D706C652D636865636B626F7827292E616464436C617373282769672D73696D706C652D636865';
+wwv_flow_api.g_varchar2_table(36) := '636B626F782D656E61626C65642729292C617065782E6974656D2E63726561746528612C7B73657456616C75652861297B672E76616C2861292C6B28297D2C64697361626C6528297B672E636C6F7365737428272E69672D73696D706C652D636865636B';
+wwv_flow_api.g_varchar2_table(37) := '626F7827292E616464436C617373282769672D73696D706C652D636865636B626F782D64697361626C656427292C672E636C6F7365737428272E69672D73696D706C652D636865636B626F7827292E72656D6F7665436C617373282769672D73696D706C';
+wwv_flow_api.g_varchar2_table(38) := '652D636865636B626F782D656E61626C656427292C672E70726F70282764697361626C6564272C2130297D2C656E61626C6528297B622E726561644F6E6C797C7C28672E636C6F7365737428272E69672D73696D706C652D636865636B626F7827292E72';
+wwv_flow_api.g_varchar2_table(39) := '656D6F7665436C617373282769672D73696D706C652D636865636B626F782D64697361626C656427292C672E636C6F7365737428272E69672D73696D706C652D636865636B626F7827292E616464436C617373282769672D73696D706C652D636865636B';
+wwv_flow_api.g_varchar2_table(40) := '626F782D656E61626C656427292C672E70726F70282764697361626C6564272C213129297D2C646973706C617956616C7565466F722861297B72657475726E20692821302C61297D7D297D7D5D293B0A';
 null;
 end;
 /

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "apex-plugin-ig_simple_checkbox",
-  "version": "18.2.2",
+  "version": "18.2.3",
   "description": "This plug-in displays a single checkbox in Interactive Grids but allows you to set 2 values (one for checked and another for unchecked). It's perfect for Y(es)/N(o) or 1/0 type checkboxes.",
   "main": "item_type_plugin_ca_trevis_apex_ig_simple_checkbox.sql",
   "scripts": {

diff --git a/src/js/ca_trevis_apex_ig_simple_checkbox.js b/src/js/ca_trevis_apex_ig_simple_checkbox.js
@@ -84,7 +84,9 @@ const init = (itemId, options) => {
             item$.val(!input$.prop('checked') ? checkedValue : uncheckedValue).change();
             updateModel(item$);
             updateDisplay();
+            return false;
           }
+          return true;
         });
       });
     };