Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve all compilation warnings #338

Merged
merged 7 commits into from
Jul 1, 2024
Merged

fix: resolve all compilation warnings #338

merged 7 commits into from
Jul 1, 2024

Conversation

CodeChenL
Copy link
Contributor

@CodeChenL CodeChenL commented Jun 27, 2024 •
edited
Loading

RadxaYuntian
RadxaYuntian requested changes Jun 27, 2024
View reviewed changes
Copy link
Member

@RadxaYuntian RadxaYuntian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

你拆分一下，按照修复的问题点来，比如把#address-cells和#size-cells的放到一个提交里

@RadxaYuntian
Copy link
Member

另外#address-cells这种确保只给需要加的节点加上了，另外可能还要检查一下base设备树的定义

@CodeChenL
Copy link
Contributor Author

CodeChenL commented Jun 27, 2024 •
edited
Loading

另外#address-cells这种确保只给需要加的节点加上了，另外可能还要检查一下base设备树的定义

回复前半句：我都是一层层往上一级节点加去测试的应该没问题吧？

@RadxaYuntian
Copy link
Member

一般上一层加了下一层可能不需要，具体我也不清楚

@CodeChenL
Copy link
Contributor Author

一般上一层加了下一层可能不需要，具体我也不清楚

我有试过去掉下层，但是会恢复报错

@CodeChenL CodeChenL force-pushed the main branch 2 times, most recently from 59dc2d1 to 1548ded Compare June 28, 2024 06:14
RadxaYuntian
RadxaYuntian requested changes Jun 28, 2024
View reviewed changes
Copy link
Member

@RadxaYuntian RadxaYuntian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

另外提交消息里面最好可以附带上dtc编译时对应的报错信息

arch/arm64/boot/dts/rockchip/overlays/rk3399-spi-gpio-enc28j60.dts Show resolved Hide resolved
arch/arm64/boot/dts/rockchip/overlays/rk3399-pwm1-ir-rx.dts Outdated Show resolved Hide resolved
RadxaYuntian
RadxaYuntian requested changes Jul 1, 2024
View reviewed changes
Copy link
Member

@RadxaYuntian RadxaYuntian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

把提交整理一下，比如那几个interrupt-parent的

RadxaYuntian
RadxaYuntian requested changes Jul 1, 2024
View reviewed changes
Copy link
Member

@RadxaYuntian RadxaYuntian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

改了直接squash，准备合并了

arch/arm64/boot/dts/rockchip/overlays/rk3528-spi0-cs1-enc28j60.dts Show resolved Hide resolved
@RadxaYuntian RadxaYuntian added this pull request to the merge queue Jul 1, 2024
Merged via the queue into radxa-pkg:main with commit fb9eb61 Jul 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RadxaYuntian RadxaYuntian RadxaYuntian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

修复编译时的一些报错
2 participants
@CodeChenL @RadxaYuntian