Refactor structure #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- created `Slack.Client` namespace - refactored all Slack classes into individual `.cs` - refactored, renamed & moved `SlackClient` class, removing `PostWebhookMessage` method - added `Authentication` class to `SlackClient`, supporting reading API token from an XML file - added `SlackRequest` class scaffold - cleaned up namespaces, removing any traces of `DynaSlack` - added `Slack.Helpers` namespace and addded `Web` class to it, which is a refactor of old `Helpers.cs` - moved Slack responses into `SlackResponse` class, from previous `Helpers.cs`
changing `SlackRequests` so it : - uses RestSharp library - follows a generic `SlackRequest` constructor - has a generic `Execute` - has a decoupled `Deserialize`
just clearing my desktop of stuff.
accidentally leaked an OAuth token as Git was still tracking keys.xml file
radumg
commented
Oct 30, 2017
| Bot bot { get; set; } | ||
| public Bot bot { get; set; } | ||
|
|
||
| public readonly string BaseUrl = "https://slack.com/api/"; |
radumg
commented
Oct 30, 2017
| public string JsonTokenOverride { get; set; } | ||
|
|
||
| internal RestClient restClient; | ||
| #endregion | ||
|
|
||
| /// <summary> | ||
| /// Slack client constructor | ||
| /// </summary> | ||
| /// <param name="token">Optional OAuth token. If not supplied or invalid, posting will only be available as bots or webhooks.</param> | ||
| /// <param name="webhook">Optional webhook override. If supplied, this will be used instead of OAuth webhook.</param> |
There was a problem hiding this comment.
remove old argument description
| @@ -0,0 +1,4 @@ | |||
| <?xml version="1.0" encoding="utf-8" ?> | |||
| <Slack> | |||
| <token>Bearer xoxp-43176652978-92379174417-214616878260-6910f9006a1700aad82d546891831fdf</token> | |||
There was a problem hiding this comment.
this should not be tracked in git.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2
fixes #3
This PR is a major structural change and breaks backwards compatibility.
As such, this will probably bump
DynaSlackto2.0.Outstanding before merging :