Sargon main branch
#53
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Alexander Cyon <[email protected]>
Co-authored-by: Alexander Cyon <[email protected]>
* BROKEN WIP | swift tests * Asserted that I can run Sargon in iOS Device, macOS Device and iOS Simulator. I can also run swift test from CLI, running Sargon Swift tests on macOS. * CI swift tests * WIP CI * non fully parallized CI * [no ci] change trigger * fix kotlin, run jvm tests in CI, try fixing code cove by installing bash. * Run kotlin tests in precommit * Revert code cov step to run on Ubuntu... awaiting macOS support. * try to fix swift tests * test fix kotlin * Remove Nextest, since it did not support running doc test, parallize Swift, Kotlin, Rust test and Code coverage. Switch code coverage to run on MacOS runner, using GH secret. * update README, change to use testDebugUnitTest for running tests * Add typos to CI * BROKEN WIP: swift tests * BROKEN WIP Swift tests * more sample addresses and swift test protocols * sample values and uniffi functoins * broken WIP * BROKEN WIP: working on Secp256k1 uncompressed * PublicKey compressed / uncompressed * more swift tests of secp256k1 * UF split * hide decimal engineering, restructure swift, add Display impl on types. * moar tests --------- Co-authored-by: Alexander Cyon <[email protected]>
* Remove getOrThrow * Add more blob extensions * Add more extension functions and properties * Add documentation and throws annotations to the rest of the methods * Add kover for Kotlin code coverage * Add tests to all known extensions * Add some missing extensions to pub methods * Add kover to precommit * Add sample testable * Add ceodecov upload task * Change coverage task * Put back all jobs on ci * Add test for hexToBagOfBytes() method * Add flags to codecov * Remove disabled tests * Add more extensions for new public methods
Create release on each push on develop
* Create extensions for TransactionManifest * Put back description for TransactionManifest
* Infra: add codecov.yml | Rust: add functions to map an address to another network & network_ids_all() | Swift: test more manifest creations methods, add logic of addresses. * Fix kotlin tests --------- Co-authored-by: Alexander Cyon <[email protected]>
* Add sample for stake claim * Expose functions for local and global ids * Rename methods in Kotlin * Add derivation path extensions * Remove hardcoded manifests from tests * Add extensions for Legacy olympia account address and samples for non fungible local id * Pr comment fixes
README: Add Badge for each "flag" (Rust, Kotlin, Swift)
* Nonce * rename fields in ExecutionSummary
Co-authored-by: Alexander Cyon <[email protected]>
* Implement Double to decimal192 * Add component address and sargon exception extensions * Move android app in examlpes dir * Create asGeneral() for addresses, signatures and public keys
Add `/transaction/preview` endpoint
* Export serde methods * Remove unecessary variable * Add kt profile extensions for serde * Add swift extensions for Profile * Separate test
Add `transaction/submit` endpoint & add unit test for GW models.
* Make Accounts -> struct instead of typealias, declared with macro: should to the same for Personas, AuthorizedDapps etc... * improve macro - use collection_type * Update Personas and FactorSources to use macro * Added kotlin extensions for personas, accounts and factor sources * Aded AuthorizedDapp in identified elements * Put get_all and get_by_id into macro --------- Co-authored-by: Alexander Cyon <[email protected]>
Add `Zeroize` on sensitive types, and new Secret Byte types, with a new `decl_secret_bytes` macro.
…s, Accounts, Personas, AuthorizedDapps etc (#81) Add mutability to collections: ProfileNetworks, FactorSources, Accounts, Personas, AuthorizedDapps etc
* Exported uniffi methods * PR comments
|
Closed since it costs money for CI... can reopen once we are closer to shipping app with Sargon, then it makes sense to "upgrade from develop to main branch" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sargon 1.0.0 will be used for the first Wallet App release we make that uses Sargon. It makes sense to create main branch (and maybe obsolete develop?).
The purpose of this PR is too gather input about some designs on how we have wrapped Radix Engine Toolkit in Sargon, specifically which functions have been made non-throwing (made to panic) - I've chosen to NOT-throwing (i.e. panic instead) in a few places, and then gather input from builders team before we merge this PR. Quiet likely code review of this PR will result in us changing some non-throwing into throwing for some RET wrapped APIs.