Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sendable Swift Types #44

Merged
merged 6 commits into from
Mar 27, 2024
Merged

Conversation

CyonAlexRDX
Copy link
Contributor

Use experimental_sendable_value_types (written by my, in PR mozilla/uniffi-rs#2045 ), which marks structs and enum's Sendable inside Sargon (bindgen generated Swift file), so that we can drop LOTS of @unchecked Sendable.

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.2%. Comparing base (d2f1495) to head (e21d0d3).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop     #44   +/-   ##
=======================================
  Coverage     99.2%   99.2%           
=======================================
  Files          358     358           
  Lines         7055    7055           
  Branches         4       4           
=======================================
  Hits          7002    7002           
  Misses          53      53           
Flag Coverage Δ
kotlin 100.0% <ø> (ø)
rust 99.1% <ø> (ø)
swift 99.7% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...wiftified/Address/ResourceAddress+Swiftified.swift 100.0% <ø> (ø)
...ied/Crypto/Derivation/AccountPath+Swiftified.swift 100.0% <ø> (ø)
...d/Crypto/Derivation/BIP44LikePath+Swiftified.swift 100.0% <ø> (ø)
...ified/Crypto/Derivation/CAP26Path+Swiftified.swift 100.0% <ø> (ø)
...ed/Crypto/Derivation/IdentityPath+Swiftified.swift 100.0% <ø> (ø)
...tified/Crypto/Derivation/Mnemonic+Swiftified.swift 100.0% <ø> (ø)
...sions/Swiftified/Crypto/Hash/Hash+Swiftified.swift 100.0% <ø> (ø)
...Swiftified/Crypto/Hash/IntentHash+Swiftified.swift 100.0% <ø> (ø)
...ftified/Crypto/Hash/PublicKeyHash+Swiftified.swift 100.0% <ø> (ø)
...fied/Crypto/Hash/SignedIntentHash+Swiftified.swift 100.0% <ø> (ø)
... and 13 more

@@ -49,15 +54,17 @@ let package = Package(
.target(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to use Swift settings in SargonUniFFI target as well but we cannot due to mozilla/uniffi-rs#2046

Base automatically changed from bump_uniffi to develop March 27, 2024 08:42
@CyonAlexRDX CyonAlexRDX merged commit d85164e into develop Mar 27, 2024
10 checks passed
@CyonAlexRDX CyonAlexRDX deleted the uniffi_27_remove_unchecked_sendable branch March 27, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants