-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sendable Swift Types #44
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #44 +/- ##
=======================================
Coverage 99.2% 99.2%
=======================================
Files 358 358
Lines 7055 7055
Branches 4 4
=======================================
Hits 7002 7002
Misses 53 53
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@@ -49,15 +54,17 @@ let package = Package( | |||
.target( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want to use Swift settings in SargonUniFFI target as well but we cannot due to mozilla/uniffi-rs#2046
Use
experimental_sendable_value_types
(written by my, in PR mozilla/uniffi-rs#2045 ), which marks structs and enum'sSendable
inside Sargon (bindgen generated Swift file), so that we can drop LOTS of@unchecked Sendable
.