Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nonce & remame Execution summary deposits/withdrawals #41

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

CyonAlexRDX
Copy link
Contributor

@CyonAlexRDX CyonAlexRDX commented Mar 26, 2024

Rename fields of ExecutionSummary:

  • addresses_of_accounts_withdrawn_from -> withdrawals
  • addresses_of_accounts_deposited_into -> deposits

Ensure Nonce is not UniFFI exported just as a typealias Nonce = UInt32 now it is a proper struct Nonce in Kotlin and Swift.

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.2%. Comparing base (75be34b) to head (ba6363a).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop     #41   +/-   ##
=======================================
  Coverage     99.2%   99.2%           
=======================================
  Files          346     348    +2     
  Lines         6980    7002   +22     
  Branches         4       4           
=======================================
+ Hits          6927    6950   +23     
+ Misses          53      52    -1     
Flag Coverage Δ
kotlin 100.0% <ø> (ø)
rust 99.1% <100.0%> (+<0.1%) ⬆️
swift 99.7% <100.0%> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...tensions/Methods/Crypto/Nonce+Wrap+Functions.swift 100.0% <100.0%> (ø)
src/core/types/nonce.rs 100.0% <100.0%> (+10.0%) ⬆️
src/core/types/nonce_uniffi_fn.rs 100.0% <100.0%> (ø)
...wrapped_radix_engine_toolkit/high_level/ret_api.rs 100.0% <ø> (ø)
...t/low_level/execution_summary/execution_summary.rs 100.0% <100.0%> (ø)

@CyonAlexRDX CyonAlexRDX merged commit e1c1481 into develop Mar 26, 2024
10 checks passed
@CyonAlexRDX CyonAlexRDX deleted the more_ios_integration branch March 26, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants