Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

olympia address #36

Merged
merged 3 commits into from
Mar 25, 2024
Merged

olympia address #36

merged 3 commits into from
Mar 25, 2024

Conversation

CyonAlexRDX
Copy link
Contributor

  • Rust + UniFFI: LegacyOlympiaAccountAddress
    • From PublicKey
    • From Str
    • To Str
    • To Babylon
    • Was Babylon Address created from Legacy
  • Swift: NonFungibleLocalID Swiftified + Tests
  • Swift: LegacyOlympiaAccountAddress

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 94.38202% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 99.2%. Comparing base (6915cf8) to head (8c186de).
Report is 10 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop     #36     +/-   ##
=========================================
+ Coverage     99.0%   99.2%   +0.1%     
=========================================
  Files          211     314    +103     
  Lines         5248    6775   +1527     
  Branches         0       4      +4     
=========================================
+ Hits          5197    6721   +1524     
- Misses          51      54      +3     
Flag Coverage Δ
kotlin 100.0% <ø> (?)
rust 99.1% <90.0%> (?)
swift 99.5% <100.0%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...s/LegacyOlympiaAccountAddress+Wrap+Functions.swift 100.0% <100.0%> (ø)
...ds/Prelude/NonFungibleLocalID+Wrap+Functions.swift 100.0% <100.0%> (ø)
...tified/Prelude/NonFungibleLocalID+Swiftified.swift 100.0% <100.0%> (ø)
...ple/Sources/Sargon/Protocols/AddressProtocol.swift 100.0% <100.0%> (ø)
...e/Sources/Sargon/Protocols/PublicKeyProtocol.swift 100.0% <100.0%> (ø)
...ddress/legacy_olympia_account_address_uniffi_fn.rs 100.0% <100.0%> (ø)
...ile/v100/address/legacy_olympia_account_address.rs 85.7% <85.7%> (ø)

... and 171 files with indirect coverage changes

}

#[uniffi::export]
pub fn legacy_olympia_account_address_is_legacy_of_babylon(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CyonAlexRDX CyonAlexRDX merged commit 061d1fd into develop Mar 25, 2024
9 of 10 checks passed
@CyonAlexRDX CyonAlexRDX deleted the olympia_address branch March 25, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants