-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check version bump when opening PRs #220
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #220 +/- ##
=====================================
Coverage 97.0% 97.0%
=====================================
Files 941 941
Lines 14863 14863
Branches 66 66
=====================================
Hits 14426 14426
Misses 430 430
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. |
e22575a
to
73a4769
Compare
@matiasbzurovski Should we maybe check to bump the version only if there are changes to rust, kotlin or swift src code? For example in the previous PR I changed the CI and the README, but didn't push any changes to src. What do you think? |
@micbakos-rdx the problem is that every time we merge into |
@matiasbzurovski At least for sargon-android a new library build is produced and published. This library gets the version from cargo toml directly and appends the commit hash as suffix. So if there is no change to the version the hash will be different. |
on iOS we set the dependency based on the release version. So, if we set it to 1.1.18, the app will use the library from such tag. However, such library has Cargo version set to For example, on this app run I use dependency |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool, lets give it a spin
Every time we forget to bump version on
Cargo.toml
, we get out of sync between the released version tag and the one indicated in such file.This PR adds a check to verify every time a PR is opened against
main
, we have changed theversion
insideCargo.toml
.You can see on this workflow run how CI failed when I had opened the PR against
main
(instead ofci/ubuntu-runners
).